perf(encode): cache isZeroer check to skip interface boxing#50
Merged
Conversation
…yValue Caches whether each struct field's type implements isZeroer at struct-discovery time. When it doesn't (the common case), skips the v.Interface().(isZeroer) type assertion in isEmptyValue, avoiding heap allocation from interface boxing on every field during OmitEmpty checks.
xe-nvdk
added a commit
that referenced
this pull request
Mar 3, 2026
The method became dead code after PR #50 switched Omit() to call isEmptyValueHint directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isZeroerat struct-discovery time (maybeZeroerfield)v.Interface().(isZeroer)boxing inisEmptyValuewhen the type doesn't implement the interfaceDetails
The
isEmptyValuefunction previously calledv.Interface().(isZeroer)on every field value, which boxes the value into aninterface{}(heap allocation) even when the type doesn't implementisZeroer. Now the check is cached once per field at struct registration time, and the boxing is skipped entirely for fields whose types don't implement the interface.Test plan