FEAT: Expo 56, Storybook and uniwind update#143
Open
HugoPerard wants to merge 7 commits into
Open
Conversation
Move the app to Expo 56, React Native 0.85, and expo-router 56, with SDK-aligned dependencies and the expo-router React Navigation import migration. Co-authored-by: Cursor <cursoragent@cursor.com>
|
🚀 Expo preview is ready!
|
| - 'react-native' | ||
| - 'react-native-*' | ||
| - '@react-native/*' | ||
| trustPolicy: no-downgrade |
There was a problem hiding this comment.
I found this on this new pnpm usage
pnpm/pnpm#12031
I don't think it is a big propblem, but maybe we should keep it in mind
There was a problem hiding this comment.
The problem seems to be related to the experimental Rust adapter - Pacquet. You haven't configured it in your project, so I think it's ok ;)
|
|
||
| const themedStyle = useThemedStyle(); | ||
|
|
||
| if (WITH_NATIVE_TABS) { |
There was a problem hiding this comment.
I don't think we need to keep this 'if'. WITH_NATIVE_TABS being always true (and maybe the énd return become useless)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.