Fix DecimalFormat locale, add BiomeUpdateTask cancellation, fix WebManager compile error#165
Merged
tastybento merged 2 commits intodevelopfrom Apr 27, 2026
Merged
Fix DecimalFormat locale, add BiomeUpdateTask cancellation, fix WebManager compile error#165tastybento merged 2 commits intodevelopfrom
tastybento merged 2 commits intodevelopfrom
Conversation
Open
…roneous IllegalAccessException catch Agent-Logs-Url: https://github.com/BentoBoxWorld/Biomes/sessions/4da75578-b144-444b-ae12-5baf3478b0d1 Co-authored-by: tastybento <4407265+tastybento@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update for new release
Fix DecimalFormat locale, add BiomeUpdateTask cancellation, fix WebManager compile error
Apr 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three unresolved review issues from the PR thread: locale-sensitive decimal formatting, cancellation not actually stopping in-progress biome updates, and a compilation error from an inapplicable
IllegalAccessExceptioncatch.Changes
Utils.java— PinDecimalFormattoLocale.ROOTviaDecimalFormatSymbols.getInstance(Locale.ROOT). Without this, servers with e.g. a German JVM locale would format0.5as0,5.BiomeUpdateTask.java— AddAtomicBoolean cancelled+cancel(). BothprocessBiomeChange(between chunks) andrunBiomeChange(before block iteration) check the flag and abort withResult.FAILED. Previously, callingcancelBiomeUpdatescompleted the future but left the task actively mutating biomes.UpdateQueue.java—cancelBiomeUpdatesnow callstask.cancel()on each matched task before completing its future, making cancellation effective for in-progress tasks.WebManager.java— Revert thecatch (IllegalAccessException e)block added in a previous commit. The BentoBox GitHub API methods don't declare that checked exception, causing a compilation failure.