Ap 527 healthcheck #11
Open
+766
−619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anarchivist
reviewed
Jan 22, 2026
Member
anarchivist
left a comment
anarchivist
left a comment
There was a problem hiding this comment.
generally looks good; i have a couple of questions. thanks for tackling this!
| @@ -0,0 +1,24 @@ | |||
| # initializers/okcomputer.rb | |||
| # Health checks configuration | |||
| require Rails.root.join('app/lib/health_checks') | |||
Member
There was a problem hiding this comment.
i think you could do the following instead:
Suggested change
| require Rails.root.join('app/lib/health_checks') | |
| require 'health_checks' |
| # Check that DB migrations have run | ||
| OkComputer::Registry.register 'database-migrations', OkComputer::ActiveRecordMigrationsCheck.new | ||
|
|
||
| # Not sure about this.... seems I need to do this in order to stub in RSPEC |
Member
There was a problem hiding this comment.
i'm not sure that this is the case. what are you running into if you don't have this environment check for the other tests?
i saw that you needed to stub OkComputer::ActiveRecordCheck.run below, which makes sense - but still, i'm not sure that you need to avoid registering the check if it's running withRAILS_ENV=test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.