Skip to content

Add pending upstream MediaElement accessibility fixes #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
awilfox merged 2 commits into from
Jan 16, 2026
+13 −15
Merged

Add pending upstream MediaElement accessibility fixes #32

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e1b004
js: Always set ARIA attributes on time scrubber
awilfox Jan 16, 2026
87c4787
js: Add volume status element to volume slider
awilfox Jan 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 13 additions & 15 deletions app/assets/javascripts/mediaelement-and-player.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1896,19 +1896,11 @@ Object.assign(_player2.default.prototype, {
t.slider.setAttribute('role', 'slider');
t.slider.tabIndex = 0;

if (media.paused) {
t.slider.setAttribute('aria-label', timeSliderText);
t.slider.setAttribute('aria-valuemin', 0);
t.slider.setAttribute('aria-valuemax', isNaN(duration) ? 0 : duration);
t.slider.setAttribute('aria-valuenow', seconds);
t.slider.setAttribute('aria-valuetext', time);
} else {
t.slider.removeAttribute('aria-label');
t.slider.removeAttribute('aria-valuemin');
t.slider.removeAttribute('aria-valuemax');
t.slider.removeAttribute('aria-valuenow');
t.slider.removeAttribute('aria-valuetext');
}
t.slider.setAttribute('aria-label', timeSliderText);
t.slider.setAttribute('aria-valuemin', 0);
t.slider.setAttribute('aria-valuemax', isNaN(duration) ? 0 : duration);
t.slider.setAttribute('aria-valuenow', seconds);
t.slider.setAttribute('aria-valuetext', time);
},
restartPlayer = function restartPlayer() {
if (new Date() - lastKeyPressTime >= 1000) {
Expand Down Expand Up @@ -3045,7 +3037,7 @@ Object.assign(_player2.default.prototype, {
mute = _document2.default.createElement('div');

mute.className = t.options.classPrefix + 'button ' + t.options.classPrefix + 'volume-button ' + t.options.classPrefix + 'mute';
mute.innerHTML = mode === 'horizontal' ? (0, _generate.generateControlButton)(t.id, muteText, muteText, '' + t.media.options.iconSprite, ['icon-mute', 'icon-unmute'], '' + t.options.classPrefix, '', t.options.classPrefix + 'horizontal-volume-slider') : (0, _generate.generateControlButton)(t.id, muteText, muteText, '' + t.media.options.iconSprite, ['icon-mute', 'icon-unmute'], '' + t.options.classPrefix, '', t.options.classPrefix + 'volume-slider') + ('<a class="' + t.options.classPrefix + 'volume-slider" ') + ('aria-label="' + _i18n2.default.t('mejs.volume-slider') + '" aria-valuemin="0" aria-valuemax="100" role="slider" ') + 'aria-orientation="vertical">' + ('<span class="' + t.options.classPrefix + 'offscreen" id="' + t.options.classPrefix + 'volume-slider">' + volumeControlText + '</span>') + ('<div class="' + t.options.classPrefix + 'volume-total">') + ('<div class="' + t.options.classPrefix + 'volume-current"></div>') + ('<div class="' + t.options.classPrefix + 'volume-handle"></div>') + '</div>' + '</a>';
mute.innerHTML = mode === 'horizontal' ? (0, _generate.generateControlButton)(t.id, muteText, muteText, '' + t.media.options.iconSprite, ['icon-mute', 'icon-unmute'], '' + t.options.classPrefix, '', t.id + '_volume-slider') : (0, _generate.generateControlButton)(t.id, muteText, muteText, '' + t.media.options.iconSprite, ['icon-mute', 'icon-unmute'], '' + t.options.classPrefix, '', t.id + '_volume-slider') + ('<a class="' + t.options.classPrefix + 'volume-slider" ') + ('aria-label="' + _i18n2.default.t('mejs.volume-slider') + '" aria-valuemin="0" aria-valuemax="100" role="slider" ') + 'aria-orientation="vertical">' + ('<span class="' + t.options.classPrefix + 'offscreen" id="' + t.id + '_volume-slider">' + volumeControlText + '</span>') + ('<div class="' + t.options.classPrefix + 'volume-total">') + ('<div class="' + t.options.classPrefix + 'volume-current"></div>') + ('<div class="' + t.options.classPrefix + 'volume-handle"></div>') + '</div>' + '</a>' + ('<span class="' + t.options.classPrefix + 'offscreen ' + t.options.classPrefix + 'volume-status" role="status">') + '</span>';

t.addControlElement(mute, 'volume');

Expand Down Expand Up @@ -3123,9 +3115,14 @@ Object.assign(_player2.default.prototype, {
mouseIsOver = false,
modified = false,
updateVolumeSlider = function updateVolumeSlider() {
var volume = Math.floor(media.volume * 100);
const volume = Math.floor(media.volume * 100);
volumeSlider.setAttribute('aria-valuenow', volume);
volumeSlider.setAttribute('aria-valuetext', volume + '%');

const statusRegion = mute.querySelector('.' + t.options.classPrefix + 'volume-status');
if (statusRegion) {
statusRegion.innerHTML = 'Volume ' + volume + '%';
}
};

var volumeSlider = mode === 'vertical' ? t.getElement(t.container).querySelector('.' + t.options.classPrefix + 'volume-slider') : t.getElement(t.container).querySelector('.' + t.options.classPrefix + 'horizontal-volume-slider'),
Expand Down Expand Up @@ -3236,6 +3233,7 @@ Object.assign(_player2.default.prototype, {
mute.addEventListener('focusin', function () {
volumeSlider.style.display = 'block';
mouseIsOver = true;
setTimeout(updateVolumeSlider, 0);
});

mute.addEventListener('focusout', function (e) {
Expand Down