Implement system_dsn for Mac #154
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alinaliBQ
reviewed
Jan 29, 2026
There was a problem hiding this comment.
Let's enable the tests in the CI as well
justing-bq
force-pushed
the
macSystemDsn
branch
6 times, most recently
from
ca40ec1 to
3aff9d5
Compare
justing-bq
force-pushed
the
macSystemDsn
branch
10 times, most recently
from
5ae6166 to
19824aa
Compare
justing-bq
force-pushed
the
macSystemDsn
branch
from
19824aa to
c6d636d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Tests were disabled due to system_dsn only being for Windows.
What changes are included in this PR?
system_dsn.h/cc have been reworked so they build on both Mac and Windows
Are these changes tested?
Yes
Are there any user-facing changes?
Yes