fix(statics): remove MultiSig feature for FLRP#9115
Merged
Conversation
mohd-kashif
approved these changes
Jun 25, 2026
ArunBala-Bitgo
approved these changes
Jun 25, 2026
Venkat-Annavazzala
approved these changes
Jun 25, 2026
Remove CoinFeature.MULTISIG_COLD and CoinFeature.MULTISIG from FLRPCoin.DEFAULT_FEATURES in modules/statics/src/flrp.ts. FLRP (Flare P-chain) is an MPC-only coin and should not offer multisig wallet creation. With these features present, supportsMultiSig() would return true for flrp/tflrp, surfacing a MultiSig wallet option in the creation flow that is not supported for this chain. Update the expectedColdFeatures test fixture to reflect that flrp and tflrp now belong in the justTSS category (TSS_COLD only, no MULTISIG_COLD) rather than the both category. Ticket: CECHO-1449 Session-Id: 1b4d90aa-156a-4a8c-8e1a-05ec6dfa64fa Task-Id: efa508db-6fe1-4074-95ae-7d62e8400f86
ArunBala-Bitgo
force-pushed
the
cecho-1449-remove-multisig-flrp
branch
from
fbea993 to
ec9b447
Compare
prithvishet2503
approved these changes
Jun 25, 2026
nvrakesh06
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
CoinFeature.MULTISIG_COLDandCoinFeature.MULTISIGfromFLRPCoin.DEFAULT_FEATURESinmodules/statics/src/flrp.tsexpectedColdFeaturestest fixture: moveflrp/tflrpfrom thebothcategory tojustTSSWhy
MULTISIG_COLDpresent,supportsMultiSig()returnstruefor flrp/tflrp, which surfaces a MultiSig wallet creation option in the UI that is not supported for this chainTest plan
cd modules/statics && yarn unit-testpasses with updated fixtureTicket: CECHO-1449