fix(sdk-coin-flrp): custody wallets no longer require a password

[bitgo-ai-agent-dev]

What

• Changed Flrp.getDefaultMultisigType() to return multisigTypes.tss (was multisigTypes.onchain)
• Updated the corresponding unit test assertion in sdk-coin-flrp
• Added a new test in the bitgo module verifying that FLRP custodial wallet generation succeeds without a passphrase

Why

• FLRP (Flare P-Chain) is a TSS-only coin: its statics include CoinFeature.TSS and CoinFeature.MPCV2 but not CoinFeature.MULTISIG. The wallet platform also enforces this — it returns "Source FLR P wallet is not MPC (multisigType: onchain)" when an onchain-type FLRP wallet is created.
• Because getDefaultMultisigType() returned 'onchain', calling generateWallet({ type: 'custodial' }) for FLRP silently defaulted to the onchain-custodial code path, producing a wallet the platform rejects and which could require a passphrase through unexpected signing paths.
• Returning 'tss' as the default causes generateWallet({ type: 'custodial' }) to route through generateCustodialMpcWallet, which creates the wallet server-side and requires no passphrase — matching the behaviour of sdk-coin-flr (FLR C-Chain), which already works correctly.

Test plan

• sdk-coin-flrp unit tests: 361 passing (all green)
• bitgo module — Generate TSS wallet tests: 52 passing (includes new FLRP test)
• New test: should create a new FLRP TSS custodial wallet without requiring a passphrase

Ticket: CECHO-1451

[linear-code]

CECHO-1451

[manojkumar138]

@claude please review

[github-actions]

Claude finished @manojkumar138's task —— View job

---

PR Review: fix(sdk-coin-flrp): custody wallets no longer require a password

Todo List:

• Read repository setup instructions (CLAUDE.md)
• Examine the three changed files
• Analyze the core logic change (onchain → tss)
• Review test changes and new test coverage
• Check for potential issues or improvements
• Provide comprehensive review feedback

---

✅ Review Summary

This PR successfully addresses the FLRP custody wallet issue by changing the default multisig type from onchain to tss. The changes are minimal, focused, and well-tested.

📋 Code Analysis

Core Change (flrp.ts:70-72)

/** inherited doc */
getDefaultMultisigType(): MultisigType {
  return multisigTypes.tss;  // ← Changed from multisigTypes.onchain
}

✅ Correctness: This change is appropriate because:

• FLRP includes CoinFeature.TSS and CoinFeature.MPCV2 in its statics
• FLRP does NOT include CoinFeature.MULTISIG
• The platform rejects onchain-type FLRP wallets with error: "Source FLR P wallet is not MPC (multisigType: onchain)"

Test Updates

1. Unit Test Update (flrp.ts:66-68)

   it('should return default multisig type', function () {
     basecoin.getDefaultMultisigType().should.equal('tss');  // ← Updated assertion
   });

2. New Integration Test (wallets.ts:813-848)

   • Tests custodial wallet generation without passphrase
   • Verifies correct routing through generateCustodialMpcWallet
   • Confirms TSS settings are fetched properly
   • Validates wallet properties match expectations

🔍 Security & Architecture Review

✅ Strengths

• Minimal surface area: Only changes the essential method
• Backward compatibility: Existing TSS wallets continue to work
• Proper test coverage: Both unit and integration tests updated
• Follows existing patterns: Matches FLR C-Chain implementation
• Clear reasoning: Well-documented in PR description

✅ Test Quality

• Comprehensive coverage: Tests both the method change and end-to-end wallet generation
• Realistic scenarios: Uses actual coin configuration (tflrp)
• Proper mocking: Correctly mocks TSS settings endpoint
• Assertion completeness: Verifies all expected wallet properties

🚀 Impact Assessment

Positive Impacts

• Fixes the root issue: Custodial wallets no longer require unexpected passphrases
• Consistent behavior: Aligns FLRP P-Chain with FLR C-Chain behavior
• Platform compatibility: Matches wallet platform expectations
• User experience: Eliminates confusing passphrase requirements for custodial flows

Risk Assessment

• Low risk: Change is isolated and well-tested
• No breaking changes: Existing functionality preserved
• Clear rollback path: Simple to revert if issues arise

🔧 Recommendations

✅ Code Quality

• Code follows repository conventions
• Proper TypeScript types used
• Conventional commit message format
• Tests pass according to PR description

💡 Future Considerations

• Consider documenting this behavior in the coin's README or docs
• Monitor for any unexpected impacts on existing FLRP wallets

✅ Approval

This PR is approved for merge. The implementation correctly addresses the stated problem with minimal risk and proper test coverage.

Key strengths:

• Precise problem identification and solution
• Minimal, focused changes
• Comprehensive test coverage
• Clear documentation of reasoning
• Follows established patterns

The change properly aligns FLRP's default behavior with its platform capabilities and user expectations.

---

🔗 Job run: https://github.com/BitGo/BitGoJS/actions/runs/12345678
🔗 Branch: fix/cecho-1451-flrp-custody-wallet-password

[manojkumar138]

LG

[kisslove-dewangan]

lgtm