feat: return undefined instead of magic string for unsigned txid - #140
Merged
Conversation
davidkaplanbitgo
approved these changes
Feb 6, 2026
Change Transaction.id and VersionedTransaction.id to return `undefined` (Option<String> in Rust) when the transaction is unsigned, instead of the magic string "UNSIGNED". This is a cleaner API that: - Forces callers to handle the unsigned case via type system - Is semantically clearer (undefined = doesn't exist yet) - Allows proper null checks instead of string comparison Ticket: BTC-3017
lcovar
force-pushed
the
BTC-3017.unsigned-to-undefined
branch
from
February 9, 2026 18:25
507a1c7 to
c7a0e81
Compare
lcovar
enabled auto-merge
February 9, 2026 18:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Transaction.id and VersionedTransaction.id to return
undefined(Option in Rust) when the transaction is unsigned, instead of the magic string "UNSIGNED".This is a cleaner API that:
Ticket: BTC-3017