fix: enable Mac builds using Homebrew LLVM #76
Merged
+54
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcovar
force-pushed
the
BTC-0-mac.build
branch
2 times, most recently
from
dd4f08b to
dad5bf6
Compare
Apple's Clang doesn't support the wasm32-unknown-unknown target, causing secp256k1-sys compilation to fail on Mac. This change automatically detects Mac and uses Homebrew's LLVM which has proper WASM support. Changes: - Makefile: Auto-detect Mac and set CC/AR to use Homebrew LLVM - Makefile: Remove trailing slashes from target declarations for compatibility with both old (Mac 3.81) and new (Linux 4.x) Make - package.json: Fix Make target names to match Makefile - scripts/wasm-pack-test.sh: Wrapper script to set correct compiler for wasm-pack tests on Mac - README.md: Update build instructions for Mac This allows Mac users to build with 'npm run build' without Docker, while maintaining full compatibility with Linux CI builds. Tested on Mac (Apple Silicon) Requires: brew install llvm" Ticket: BTC-0
lcovar
force-pushed
the
BTC-0-mac.build
branch
from
dad5bf6 to
aef4bab
Compare
OttoAllmendinger
approved these changes
Dec 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apple's Clang doesn't support the wasm32-unknown-unknown target, causing secp256k1-sys compilation to fail on Mac. This change automatically detects Mac and uses Homebrew's LLVM which has proper WASM support.
Changes:
compatibility with both old (Mac 3.81) and new (Linux 4.x) Make
for wasm-pack tests on Mac
This allows Mac users to build with 'npm run build' without Docker, while maintaining full compatibility with Linux CI builds.
Tested on Mac (Apple Silicon)
Requires: brew install llvm"
Ticket: BTC-0