fix: BIP-39 per-word validation during cipher recovery#235
Open
BitHighlander wants to merge 3 commits into
Open
fix: BIP-39 per-word validation during cipher recovery#235BitHighlander wants to merge 3 commits into
BitHighlander wants to merge 3 commits into
Conversation
1. Per-word rejection: invalid BIP-39 words rejected immediately during cipher entry with "Word not found in BIP39 wordlist" + OLED warning 2. Condition flip: !enforce_wordlist -> enforce_wordlist at finalization 3. Previous word display: shows "(N.word)" during cipher entry 4. layout_cipher: added prev_word_info parameter C31 test should now PASS with OLED screenshot.
deps/device-protocol → 8ef74da (feat(ripple): memo + THORChain routing) deps/python-keepkey → bf870e6 (7.14.2: XRP memo + EVM depositWithExpiry + msg-signing)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
prev_infobuffer from 16 to 24 bytes to silence-Wformat-truncationTest plan