fix: EIP-712 cancel propagation and strtoll input validation#239
Open
BitHighlander wants to merge 2 commits into
Open
fix: EIP-712 cancel propagation and strtoll input validation#239BitHighlander wants to merge 2 commits into
BitHighlander wants to merge 2 commits into
Conversation
Bug 1 (cancel ignored): confirmName() and confirmValue() cast review() return value to void, allowing signing to continue after user presses cancel. Added USER_CANCELLED error code and propagate cancellation up through the call chain. Bug 2 (strtoll overflow/garbage): strtoll() was called with NULL endptr, silently accepting trailing garbage and wrapping on overflow. Added endptr validation to reject non-numeric input, and reject negative values for uint types.
deps/device-protocol → 8ef74da (feat(ripple): memo + THORChain routing) deps/python-keepkey → bf870e6 (7.14.2: XRP memo + EVM depositWithExpiry + msg-signing)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two EIP-712 signing security fixes:
Cancel ignored:
confirmName()andconfirmValue()castreview()return to void, so pressing cancel on the device didn't stop signing. AddedUSER_CANCELLEDerror code and propagate it up through the call chain.strtoll overflow/garbage:
strtoll()was called withNULLendptr, silently accepting trailing garbage and undefined behaviour on overflow. Added endptr validation and rejection of negative values foruinttypes.Test plan
ActionCancelled