fix: use instruction decimals for Solana TransferChecked amount display#242
Open
BitHighlander wants to merge 2 commits into
Open
fix: use instruction decimals for Solana TransferChecked amount display#242BitHighlander wants to merge 2 commits into
BitHighlander wants to merge 2 commits into
Conversation
For SOL_INSTR_TOKEN_TRANSFER_CHECKED the instruction data encodes the authoritative decimal count in byte 9 (parsed into pi->extra_u8). The host-supplied SolanaTokenInfo.decimals is metadata only and could be forged to misrepresent the displayed amount. Split the fallthrough case so TRANSFER_CHECKED always uses pi->extra_u8 for decimal scaling while still displaying the host-supplied symbol as a label.
deps/device-protocol → 8ef74da (feat(ripple): memo + THORChain routing) deps/python-keepkey → bf870e6 (7.14.2: XRP memo + EVM depositWithExpiry + msg-signing)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SOL_INSTR_TOKEN_TRANSFER_CHECKED, the instruction data encodes the authoritative decimal count at byte 9 (pi->extra_u8). The host-suppliedSolanaTokenInfo.decimalsis metadata only and can be forged to misrepresent the displayed token amount.TOKEN_TRANSFER/TOKEN_TRANSFER_CHECKEDfallthrough into separate cases soTRANSFER_CHECKEDalways usespi->extra_u8for decimal scaling.TOKEN_TRANSFER(no decimals in instruction) continues to useti->decimalsfrom host metadata as before.Files Changed
lib/firmware/fsm_msg_solana.h— splitSOL_INSTR_TOKEN_TRANSFER_CHECKEDcase, usepi->extra_u8for decimalsTest Plan
transfer(non-checked): displayed decimals match host metadata as beforetransferChecked: displayed decimals match instruction bytes, not host metadataSolanaTokenInfofor atransferCheckedtx: device shows correct amount from instruction