fix: return merkle branch roots by requested type#7
Open
pinehill99 wants to merge 2 commits into
Open
Conversation
|
Review-assist pass for the #39/#81 bounty context: This is a clean, narrow fix candidate: the current implementation returns bytes for Before merging, I would ask for three quick maintainer checks:
No claim/payment action from me here; this is just a review-assist note to make the bounty acceptance criteria explicit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
Note: python3 -m unittest pybgl.test.block -q cannot load in this local checkout because native _sha3_hash is not built; it fails before tests run. The change is isolated to the pure-Python merkle branch helper.
Bounty context: BitgesellOfficial/bitgesell#39 and BitgesellOfficial/bitgesell#81.