fix(EasterEgg): eliminate key-repeat and load-race bugs in the typing game and Konami code - #462
Merged
Conversation
…r load Starting a round before the async high-score load resolved defaulted highScore to 0, so a fast game always looked like a new record and overwrote a genuinely higher saved score. Block game start until the load finishes.
tanahiro2010
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves TypingGame input reliability and high score correctness by ensuring the saved high score is loaded before gameplay begins and by suppressing auto-repeat keydown events that can cause unintended extra inputs.
Changes:
- Added a
highScoreLoadedflag in the game ref state and set it after the high score load attempt finishes (success or failure). - Prevented
startGame()from running until the high score load has completed. - Ignored repeated keydown events (
KeyboardEvent.repeat) to avoid duplicate character inputs when a key is held down.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tanahiro2010
changed the title
tanahiro2010
changed the title
tanahiro2010
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TypingGame's keydown handler against OS key-repeat (e.repeat), which was letting a single held keypress register as multiple typed characters, corrupting combo/score and mis-firing typos.startGame()until the async high-score load resolves, so a fast round finished before the store read completes no longer overwrites a genuinely higher saved high score with a lower one.useKonamiCode, where a held key could otherwise silently reset the whole 10-key sequence (worse than the typing game case, since one bad repeat wipes all prior progress with no feedback).Why
All three bugs share the same root cause: neither keydown handler checked
e.repeat, so holding a key slightly too long — very easy to do by accident — produced synthetic repeated keydown events that the game/hook logic wasn't designed to expect.Test plan
b) slightly too long and confirm the sequence progress isn't reset