Conversation
There was a problem hiding this comment.
Pull request overview
This PR implements multiobjective experiment support by adding an optional UI label field to score variables and creating a new multiobjective experiment initialization option.
Changes:
- Added optional
labelfield to score variables for UI display (defaults tonameif not provided) - Added
initialStateMultiObjectivestate with two score variables and a button to create multiobjective experiments - Updated table headers and cells to display
label ?? namefor score variables
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| sample-app/src/experiment-container.tsx | Reads multiObjective query parameter and passes it to ExperimentProvider |
| sample-app/src/components/home/home.tsx | Adds new button and handler to create multiobjective experiments |
| packages/ui/src/features/data-points/useDataPoints.ts | Updates score names to include label field and propagates it through data structures |
| packages/ui/src/features/core/editable-table/types.ts | Adds optional label field to TableDataPoint type |
| packages/ui/src/features/core/editable-table/editable-table.tsx | Updates table headers/footers to display label instead of name |
| packages/ui/src/features/core/editable-table/editable-table-expanded-row.tsx | Updates expanded row headers to display label instead of name |
| packages/core/src/context/experiment/store.ts | Adds initialStateMultiObjective with two score variables and updates default score variable structure |
| packages/core/src/context/experiment/experiment-reducers.ts | Updates score variable creation to use label field |
| packages/core/src/context/experiment/experiment-context.tsx | Adds isMultiObjective prop to conditionally use multiobjective initial state |
| packages/core/src/common/util/migration/schemas/17.json | Adds optional label field to score variable schema |
| packages/core/src/common/types/common.ts | Defines scoreNames and scoreLabels constants |
| README.md | Adds note about building packages with watch mode |
| .changeset/nervous-points-move.md | Documents the multiobjective feature addition |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 22 out of 22 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
packages/core/src/common/util/migration/migrations/migrateToV18.ts
Outdated
Show resolved
Hide resolved
packages/core/src/common/util/migration/migrations/migrateToV18.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 27 out of 27 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
packages/core/src/common/util/migration/migrations/migrateToV18.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 26 out of 26 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Uh oh!
There was an error while loading. Please reload this page.