chore(dashboard): wave 2 of code-health audit fixes#103
Merged
pratyush618 merged 2 commits intomasterfrom May 2, 2026
Merged
Conversation
Extract parseRefreshOption + refreshIntervalMs as pure helpers from the provider and cover them with vitest. Captures the localStorage guard logic (audit's flagged regression risk) without dragging in jsdom + testing-library.
Both noStaticElementInteractions and useKeyWithClickEvents were toggled off historically. Re-running biome check confirms no current violations, so flip them to error as a guard against future div-with-onClick regressions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to PR #102. Picks up two of the three audit items deferred from
that PR:
refresh-interval-provider— extractsparseRefreshOption()andrefreshIntervalMs()as pure helpers andadds 6 tests covering the localStorage guard logic (the audit's flagged
regression risk). Avoids dragging in
jsdom+@testing-library/reactfor what is essentially validation of a string union.
noStaticElementInteractionsanduseKeyWithClickEvents, both previously toggled off. Runningbiome checkconfirms zero current violations across all 170 files;the rules act as a guard against future div-with-onClick regressions.
Deliberately deferred
The third audit item (hoisting
ToggleBtn/ViewToggleout ofroutes/dead-letters.tsxandDateInput/msToLocalDatetimeout offeatures/jobs/components/job-filters.tsx) is not in this PR. Bothhave exactly one consumer each — hoisting them now would be premature
abstraction. Worth revisiting only when a second feature actually needs
them.
Test plan
pnpm run ci(biome ci, typecheck, 87 vitest tests, vite build) clean locally