-
-
Notifications
You must be signed in to change notification settings - Fork 65
Fixup GAS/binutils assembly #762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -146,4 +146,4 @@ _os_GetStringInput: | |
| ld (ti.curRow), hl | ||
| jp .L.start | ||
|
|
||
| extern __frameset0 | ||
| .extern __frameset0 | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -146,4 +146,4 @@ _os_GetTokenInput: | |
| ex de, hl | ||
| jp .L.start | ||
|
|
||
| extern __frameset0 | ||
| .extern __frameset0 | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| .assume adl = 1 | ||
| .assume adl=1 | ||
|
|
||
| .section .init.weak_crt,"ax",@progbits | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| #include "crt.h" | ||
|
|
||
| .assume adl = 1 | ||
| .assume adl=1 | ||
|
|
||
| .equ ti.mpTmr1Counter, 0x0F20000 | ||
| .equ ti.mpTmrCtrl, 0x0F20030 | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,7 +5,7 @@ | |
| .global __dneg | ||
| .type __dneg, @function | ||
|
|
||
| ; .assumes BC:UDE:UHL | ||
| ; assumes BC:UDE:UHL | ||
| __dneg: | ||
| rl b | ||
| ccf | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| .assume adl = 1 | ||
| .assume adl=1 | ||
|
|
||
| .global _errno | ||
| .equ _errno, 0xD008DC |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,7 +6,7 @@ | |
|
|
||
| __fpupop2: | ||
| push bc | ||
| ld bc, 0800000h | ||
| ld bc, 0x800000 | ||
| add hl, bc | ||
| jr nc, .ncarry | ||
| add hl, bc | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -23,4 +23,5 @@ __lpopcnt: | |
| pop hl | ||
| ret | ||
|
|
||
| .extern __popcnt_common_init_full, __popcnt_common_iter_adjusted | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. not sure if this is a valid extension or not, but we only use |
||
| .extern __popcnt_common_init_full | ||
| .extern __popcnt_common_iter_adjusted | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| .assume adl = 1 | ||
| .assume adl=1 | ||
|
|
||
| .section .text._malloc | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,8 +2,8 @@ | |
|
|
||
| .section .text | ||
| .global _ceil | ||
| .global _ceilf | ||
| .type _ceil, @function | ||
| .global _ceilf | ||
| .type _ceilf, @function | ||
|
|
||
|
Comment on lines
4
to
8
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this is what I mean by canonicalizing the order of |
||
| .ifdef PREFER_OS_LIBC | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| .assume adl = 1 | ||
| .assume adl=1 | ||
|
|
||
| .section .text | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,7 +5,6 @@ | |
| .global _memmem | ||
| .type _memmem, @function | ||
| .local _memcmp_fast | ||
| .type _memcmp_fast, @function | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
|
|
||
| ; void *memmem(const void *haystack, size_t haystack_len, const void *needle, size_t needle_len) | ||
| .equ haystack, 3 | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,6 +2,7 @@ | |
|
|
||
| .section .text | ||
| .global _strdup | ||
| .type _strdup, @function | ||
| _strdup: | ||
| pop de | ||
| ex (sp), hl | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,6 +3,7 @@ | |
| .section .text | ||
|
|
||
| .global _strlcat | ||
| .type _strlcat, @function | ||
|
|
||
| _strlcat: | ||
| ld iy, 0 | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,6 +2,7 @@ | |
|
|
||
| .section .text | ||
| .global _strlen | ||
| .type _strlen, @function | ||
|
|
||
| .ifdef PREFER_OS_LIBC | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@calc84maniac is this
.localfunction supposed to have@function?