Skip to content

Update json dep#14

Merged
exaexa merged 6 commits intomasterfrom
sew-up-json
Oct 7, 2025
Merged

Update json dep#14
exaexa merged 6 commits intomasterfrom
sew-up-json

Conversation

@stelmo
Copy link
Copy Markdown
Member

@stelmo stelmo commented Oct 6, 2025

JSON.jl v1 recently got merged

@stelmo stelmo requested a review from exaexa October 6, 2025 17:08
@stelmo
Copy link
Copy Markdown
Member Author

stelmo commented Oct 6, 2025

I will fix these problems this week

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 7, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (60a8eb9) to head (07b0dc0).

Additional details and impacted files 
@@            Coverage Diff            @@
##            master       #14   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         6    +1     
  Lines          196       197    +1     
=========================================
+ Hits           196       197    +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

exaexa
exaexa requested changes Oct 7, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@exaexa exaexa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the self-conversion line is for whichever reason not triggered, which sounds weird (it should be by AFBCMs tests).

exaexa
exaexa requested changes Oct 7, 2025
View reviewed changes
Comment thread .github/workflows/ci.yml Outdated
Comment thread Project.toml Outdated
Comment thread e_coli_core.json Outdated
Comment thread src/types.jl Outdated
@stelmo
Copy link
Copy Markdown
Member Author

stelmo commented Oct 7, 2025

/format

@stelmo
Copy link
Copy Markdown
Member Author

stelmo commented Oct 7, 2025

I made it a 2.0 release, since keeping it lower will require access to JSON.Object which seems to be a 1.0 type

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 7, 2025

✔️ Auto-formatting triggered by this comment succeeded, commited as 5232659

github-actions Bot pushed a commit that referenced this pull request Oct 7, 2025
@stelmo
automatic formatting
5232659 
triggered by @stelmo on PR #14
@stelmo
Copy link
Copy Markdown
Member Author

stelmo commented Oct 7, 2025

/format

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 7, 2025

✔️ Auto-formatting triggered by this comment succeeded, commited as 3b5beea

github-actions Bot pushed a commit that referenced this pull request Oct 7, 2025
@stelmo
automatic formatting
3b5beea 
triggered by @stelmo on PR #14
@stelmo @exaexa
automatic formatting
07b0dc0 
triggered by @stelmo on PR #14
exaexa
exaexa approved these changes Oct 7, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@exaexa exaexa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks OK now, I re-triggered the CI on a clean commit to get 💯 cover confirmed automatically on the last commit

@exaexa
Copy link
Copy Markdown
Member

exaexa commented Oct 7, 2025

ok good I guess

@exaexa exaexa merged commit e260f50 into master Oct 7, 2025
3 checks passed
@exaexa exaexa deleted the sew-up-json branch October 7, 2025 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@exaexa exaexa exaexa approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@stelmo @codecov-commenter @exaexa