fix(JinjaSetup): remove unreachable return None; use Exception not BaseException - #168
Open
SoundMatt wants to merge 1 commit into
Open
Conversation
…seException Two small fixes: 1. `return None` at the end of `render_node` is unreachable: every code path before it either raises or returns. Removed. 2. `GeneratorError` subclassed `BaseException` directly, bypassing normal `except Exception` handlers. Changed to `Exception`. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Matt Jones <47545907+SoundMatt@users.noreply.github.com>
Collaborator
|
Similar to #167 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small fixes in
JinjaSetup.py:return Noneat the bottom ofrender_nodeis unreachable: every code path above it either raises or returns a value. Removed.GeneratorErrorsubclassedBaseExceptiondirectly, which bypasses normalexcept Exceptionhandlers in calling code. Changed to subclassException.