fix(JinjaSetup, TemplateDir): bind root from os.walk to fix NameError in recursive search - #175
Open
SoundMatt wants to merge 1 commit into
Open
Conversation
…ecursive template search Both `find_matching_template_files` functions discarded the first value from `os.walk` using `_`, then constructed file paths with `root` — a variable that was therefore never defined, causing a `NameError` when the recursive code path was taken. Capture it as `root`. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Matt Jones <47545907+SoundMatt@users.noreply.github.com>
Collaborator
|
Some of the oldest template handling might have left obsolete code, but this TemplateDir.py is referenced from JinjaTemplateEnvk, so I think the code is used. But how does it then work despite the described problem? Test / review and possibly remove now obsolete implementations. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both
find_matching_template_filesimplementations unpackedos.walkasfor _, _, filenames, discarding therootdirectory string. The body then built file paths usingos.path.join(root, ff), referencing an undefined variable. Calling either function withrecurse=Trueraises aNameError.Fix by binding the first value to
rootinstead of discarding it with_.