fix(protobuf_lark): replace undefined TypeException with TypeError#178
Open
SoundMatt wants to merge 1 commit into
Open
fix(protobuf_lark): replace undefined TypeException with TypeError#178SoundMatt wants to merge 1 commit into
SoundMatt wants to merge 1 commit into
Conversation
… matcher `TypeException` is not defined anywhere; the standard built-in is `TypeError`. Hitting the else-branch of `matcher()` would raise a `NameError` instead of the intended exception. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Matt Jones <47545907+SoundMatt@users.noreply.github.com>
Collaborator
|
Combine with #162 and update in all places where TypeException is mentioned. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TypeExceptionis not defined anywhere in the codebase. Theelsebranch ofmatcher()would raise aNameErrorinstead of the intended error when an unexpected node type is passed. Replace with the standardTypeError.