fix(trino): URL-decode credentials and identifiers from connection URL

[Bartok9]

Summary

• _parse_trino_url now unquote()s the username, password, catalog, and schema parsed out of the connection URL.
• Fixes auth/connection failures when a credential or identifier contains a reserved character that must be percent-encoded in the URL.

Motivation

_parse_trino_url (in core/wren/src/wren/connector/trino.py) parsed a trino://user:pass@host:port/catalog/schema URL and put parsed.username / parsed.password / the catalog+schema path parts straight into the connect kwargs.

urllib.parse.urlparse leaves percent-encoded characters in the userinfo and path. Credentials and identifiers can contain reserved characters (@, /, :, ?) that must be percent-encoded for the URL to parse — so a password like p@ss/word (...:p%40ss%2Fword@...) reached Trino as the literal p%40ss%2Fword, and a catalog named cat/alog (cat%2Falog) was mis-parsed.

The mssql, mysql, clickhouse, and oracle connectors already unquote() these components. This brings Trino in line. unquote (not unquote_plus) is used so a literal + in a credential is preserved.

Verification

Real output on current upstream/main (fix reverted, tests present):

E         - us@er
E         + us%40er
FAILED tests/connectors/test_trino.py::test_parse_trino_url_decodes_percent_encoded_credentials
1 failed, 4 passed

With the fix applied:

python3 -m pytest tests/connectors/test_trino.py -k parse_trino_url -q
5 passed, 66 deselected in 0.46s

• Two new regression tests (pure parser, no Trino container): one asserts percent-decoding of user/password/catalog/schema, one asserts a literal + is preserved.
• Path is Apache-2.0 (core/**).

Summary by CodeRabbit

• Bug Fixes

  • Improved Trino connection URL handling so encoded characters in usernames, passwords, catalog, and schema are decoded correctly.
  • Preserved literal + characters in credentials instead of treating them as spaces.
  • Kept existing connection defaults and URL validation behavior unchanged.

• Tests

  • Added coverage for percent-decoding in Trino connection URLs.
  • Added coverage to ensure + characters in credentials remain intact.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 51d715c8-9fb6-4e74-802b-cc89aaef9a7b

📥 Commits

Reviewing files that changed from the base of the PR and between 5ff51e4 and 704e2cf.

📒 Files selected for processing (2)

• core/wren/src/wren/connector/trino.py
• core/wren/tests/connectors/test_trino.py

---

Walkthrough

The Trino connector's _parse_trino_url function now percent-decodes the user, catalog, schema, and password URL components using unquote. New unit tests verify correct decoding of encoded credentials and that literal + characters in credentials remain unaffected.

Changes

Trino URL Decoding

Layer / File(s)	Summary
Percent-decode connection URL components core/wren/src/wren/connector/trino.py	Imports unquote and applies it to decode user, catalog, schema, and password fields when parsing Trino connection URLs.
Decoding test coverage core/wren/tests/connectors/test_trino.py	Adds tests confirming percent-encoded credentials/path segments decode correctly and literal + characters are preserved.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Suggested reviewers: goldmedal

Poem

A rabbit hopped through URLs so tangled,
Percent signs decoded, credentials untangled,
No more %40 where an @ should be,
Plus signs stay plus, safe and free! 🐇✨
Hop, hop, hooray for clean parsing today!

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main change: decoding Trino URL credentials and path identifiers.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}