use a line channel per task - #454
Open
Canop wants to merge 2 commits into
Open
Conversation
Removes the (theoretical, only with non default settings) risk of having one line leak from a killed command to the next one.
There was a problem hiding this comment.
Pull request overview
This PR updates the execution plumbing so each task execution uses its own output-line channel, preventing output from a killed command from being observed by the next command under certain (non-default) configurations.
Changes:
- Move the line output receiver from
MissionExecutortoTaskExecutor, creating a fresh channel per task execution. - Add a “keepalive” sender to prevent
select!from busy-looping on a disconnected line channel after a task ends. - Refactor child-process shutdown to
wait()exactly once and avoid panicking onkill()errors.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/tui/app.rs |
Switches the UI event loop to receive command output from the per-task receiver. |
src/exec/executor.rs |
Creates a per-task line channel, keeps it connected until task replacement, and refines kill/wait behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the (theoretical, only with non default settings) risk of having one line leak from a killed command to the next one.