Skip to content

Allow commander to be any creature if not enforcing deck conformity#9916

Merged
Jetz72 merged 2 commits intoCard-Forge:masterfrom
dkrako:patch-1
Mar 5, 2026
Merged

Allow commander to be any creature if not enforcing deck conformity#9916
Jetz72 merged 2 commits intoCard-Forge:masterfrom
dkrako:patch-1

Conversation

@dkrako
Copy link
Contributor

@dkrako dkrako commented Feb 25, 2026

Deactivating deck conformity check did not have any effect on the available commanders.

This change allows any creature to be set as commander.

@Jetz72 Jetz72 added Mobile Deck Editor Anything related to the mobile or desktop deck editors labels Feb 25, 2026
@Jetz72
Copy link
Contributor

Jetz72 commented Feb 25, 2026

Huh. Guess I added this option for partner commanders but not for the main one? Seems valid to me.

@dkrako
Copy link
Contributor Author

dkrako commented Mar 4, 2026

Thanks for the feedback. Are there any tests that I should add?

I didn't check if the issue also exists on the desktop app.

@dkrako dkrako marked this pull request as ready for review March 4, 2026 17:06
Copy link
Contributor

@Jetz72 Jetz72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback. Are there any tests that I should add?

Nah. We don't usually maintain tests for things as nuanced as this.

I didn't check if the issue also exists on the desktop app.

Probably does. Though there's some other disparity between the editors here anyway. The mobile UI separates the conformity toggle in the deck validator (i.e. when you're starting the match) from the conformity toggle in the deck editor. Disabling the editor conformity toggle is meant to remove all the guardrails for deck-building, even the ones many players would want to adhere to anyway (e.g. it'll start asking you how many copies of cards you want in a deck designed for a singleton format).

@Jetz72 Jetz72 merged commit 75823f3 into Card-Forge:master Mar 5, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Deck Editor Anything related to the mobile or desktop deck editors Mobile

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants