Skip to content

[ENG-10045] Search facet search fields are very rigid and inconsistent #864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adlius merged 1 commit into from
Jan 27, 2026
Merged

[ENG-10045] Search facet search fields are very rigid and inconsistent #864

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions src/app/shared/components/generic-filter/generic-filter.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +0,0 @@
::ng-deep .scrollable-panel {
.p-select-panel {
max-height: 300px;
overflow: hidden;
}

.p-select-items-wrapper {
max-height: 250px;
overflow-y: auto;
}
}
4 changes: 2 additions & 2 deletions src/app/shared/components/generic-filter/generic-filter.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ export class GenericFilterComponent {
const isSearching = this.isActivelySearching();

if (isSearching && this.stableOptionsArray.length > 0) {
return this.stableOptionsArray;
return [...this.stableOptionsArray];
}

let newOptions: FilterOption[];
Expand All @@ -68,7 +68,7 @@ export class GenericFilterComponent {
}

this.updateStableArray(newOptions);
return this.stableOptionsArray;
return [...this.stableOptionsArray];
});

selectedOptionValues = computed(() => this.selectedOptions().map((option) => option.value));
Expand Down
2 changes: 1 addition & 1 deletion src/app/shared/components/search-filters/search-filters.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@

@if (splitFilters().grouped.length > 0) {
<p-accordion-panel [value]="'is-present-group'">
<p-accordion-header>{{ 'Additional Filters' }}</p-accordion-header>
<p-accordion-header>{{ 'collections.filters.additionalFilters' | translate }}</p-accordion-header>
<p-accordion-content>
<div class="flex flex-column gap-2">
@for (filter of splitFilters().grouped; track filter.key) {
Expand Down
6 changes: 4 additions & 2 deletions src/app/shared/stores/global-search/global-search.state.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,7 @@ export class GlobalSearchState {
...this.buildParamsForIndexCardSearch(state),
'page[size]': '200',
valueSearchPropertyPath: filterKey,
valueSearchText: valueSearchText ?? '',
valueSearchText: valueSearchText ? `${valueSearchText}*` : '',
};
}

Expand All @@ -315,7 +315,9 @@ export class GlobalSearchState {

filtersParams['cardSearchFilter[resourceType]'] = getResourceTypeStringFromEnum(state.resourceType);
filtersParams['cardSearchFilter[accessService]'] = `${this.environment.webUrl}/`;
filtersParams['cardSearchText[*,creator.name,isContainedBy.creator.name]'] = state.searchText ?? '';
filtersParams['cardSearchText[*,creator.name,isContainedBy.creator.name]'] = state.searchText
? `${state.searchText}*`
: '';
filtersParams['page[size]'] = '10';

const sortBy = state.sortBy;
Expand Down
1 change: 1 addition & 0 deletions src/assets/i18n/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1316,6 +1316,7 @@
"noFiltersAvailable": "No filters available",
"noOptionsAvailable": "No options available",
"searchCreators": "Search for creators",
"additionalFilters": "Additional Filters",
"programArea": {
"label": "Program Area",
"placeholder": "Select program areas",
Expand Down