Repository navigation
refactor: remove the unreachable ExecGate; refresh docs and counts (#55) - #74
Merged
Merged
Conversation
1 task done
4 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Part of #55 (Task 6, the last task of the plan: remove ExecGate, refresh docs and counts).
What changes
POST /containers/create), and the router denies every exec path before that (segment-exact since Routing parity: TS path-wide exec deny; Go matchEndpoint accepts endpoint subpaths #49, for every method), so the gate could never fire. Its tests go too, including the two chain tests that called the chain directly with an exec path (Rusttest_chain_execute_denies_exec_via_gate, TS "denies exec request"); exec denial is covered by the router tables, the spec (execNeverAllowed,emptySegmentsHideNoExec) and the integration suite.spec/docker_socket_policy.qnt: the exec rows are{ method: "*", path: "/containers/:name/exec" }and{ method: "*", path: "/exec/*" }, matching the router (any method).spec/README.md: listsemptySegmentsHideNoExec, fixes a missing comma.spec/listener-design.md: the numeric-gid wording matches the normative table (digits only,0-4294967294; larger exits 2).deploy/test.shheader: ExecGate dropped from the list.Counts (before → after)
The Go total is unchanged because #71 and #72 each added one proxy test and this PR removes two middleware tests. (The docs before this PR still said Go 108, Rust 145, TS 162; they had not been updated by #71–#73.)
Review notes
bump=patch tag=v0.3.7.Verification
make test-all: Go ok, Rust143 passed, TS161 tests, 160 pass, 1 skipped.make lint-all,make typecheck,make test-release(51 passed,9 passed) pass.make test-spec: all 6 runs pass.make verify:[ok] No violation found(both modules).ALL 45 TESTS PASSED; CI runs all three.grep -rni execgateover the tracked sources and docs (excluding plans) finds nothing.Type of change
Implementation(s) changed
Testing
make test-all)make verify,make test-spec)Checklist