fix(auth): clarify login identifier field - #3004
Open
lntutor wants to merge 5 commits into
Open
Conversation
Co-Authored-By: OpenAI Codex <noreply@openai.com>
lntutor
requested review from
asvishnyakov,
hayescode and
sandangel
as code owners
July 31, 2026 13:20
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 4 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Co-Authored-By: Codex <codex@openai.com>
Co-Authored-By: OpenAI Codex <noreply@openai.com>
Co-Authored-By: OpenAI Codex <noreply@openai.com>
dokterbob
requested changes
Aug 17, 2026
dokterbob
left a comment
Collaborator
There was a problem hiding this comment.
Interesting contribution. Just, I am wondering whether it'll actually reduce confusion, overall: some users will user usernames, others will use emails, some will use both.
Perhaps a more 'neutral' way is to just talk about 'Login', which is close enough to identifier that developers will understand it and close enough to username that users might.
Let me know how you feel about this. Appreciate the added frontend unit test, for sure!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Clarified the login identifier by changing the field from “Email address” to “Username or email” and submitting it as
username. This removes confusion for users who sign in with a username.email→username; addedautocomplete="username"; validation errors now show on submit.usernameto the API.username.Written for commit b656b28. Summary will update on new commits.