-
Notifications
You must be signed in to change notification settings - Fork 353
feat(flags): ast 116512 support new cloud providers ibm cloud and oracle cloud #7887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat(flags): ast 116512 support new cloud providers ibm cloud and oracle cloud #7887
Conversation
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 9411235 | Triggered | Generic Password | d26d813 | teste/vulnerable-node-master/docker-compose.yml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @cx-laura-rodrigues,
Everything looks good, great addition of the 2 new cloud providers 😃!
I believe we don't need both images for oraclecloud since we no longer support dark version on kics official documentation but it doesn't hurt to have it.
We could also add coverage for the flag --cloud-provider with the new added CP just to make sure it works corretly.
I'll ask the rest of the team to review the pull request as well and have their input here.
Thanks for the amazing job done!








Proposed Changes
I submit this contribution under the Apache-2.0 license.