Proposal: change 1 second hold to hitting L/R or ZL/ZR buttons 3 times for song skip

[ColAlexsanders]

I saw that you were working on this issue too and made a pull request to the main project, so I decided to fork your version to address this matter.

While walking around with my 3ds ("New" 3ds regular size) in my pocket, I still had issues with song skips even with the 1 second hold (especially at the gym during sets). I changed it to 2 seconds, but unwanted skips would still occur on a common basis.

I then decided to try a three-time button press for the buttons, and that made song skips much less common, almost negating the issue in fact. I made it to where the buttons have to get pressed 3 times in under 500ms, but unwanted song skips still can happen I'm sure.

There is more info in the readme and main.c file for what I did exactly.

[CinisSec]

Thank you for the pull request! I'll test it on my machine.

[ColAlexsanders]

By the way I thought that I committed the current version that I have locally where the skip window is under 300ms (I still found issues with 500ms skip window still skipping songs somewhat often), but all you need to do i change the 1000 if (zrPressTime - zrPressCount[i] <= 1000) to 300, along with the equivalent lines for the other bumpers. Even then, I still found that song skips would happen relatively often if I were to go running even with the 1 second wait cooldown. The only other way I can think of to solve that without sacrificing modularity is to program a mode that disables song skipping with the buttons, but I haven't thought about it much further than that due to other projects for school.

I can go commit that version when I get home later today if you aren't able to take a look at it before then. I apologize for this mishap.

[CinisSec]

No worries, take your time ~
I'm not in a hurry to test it as I am busy myself. :)

[ColAlexsanders]

Turns out the version that I was using was the 500ms skip window version, so I tested the 300ms one and found that one to be too quick. Tested with 400ms and I believe that would make for the best compromise. Updating the skip cooldown to 2 seconds may also help with unwanted skips during intense physical activities too.

Other than the if statements potentially needing some work in terms of looks, the functionality itself is working as expected.