🎨 Palette: Synchronize aria-keyshortcuts on shortcut toggle - #437
🎨 Palette: Synchronize aria-keyshortcuts on shortcut toggle#437ightevenmckane187 wants to merge 1 commit into
Conversation
Dynamically remove and restore aria-keyshortcuts attributes on interactive shortcut elements when global single-key keyboard shortcuts are toggled off or on. This prevents screen readers from making misleading announcements about shortcuts when they are disabled.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
💡 What: Enhanced single-key shortcut toggle to dynamically add/remove
aria-keyshortcutsattributes on interactive elements (.theme-toggle,#user-id-input,#create-session-btn,#copy-curl, and#extend-session-btn).🎯 Why: Screen reader users were previously announced key shortcuts even when the user had explicitly toggled single-key shortcuts off in the interface.
♿ Accessibility: Ensures compliance with WCAG 2.1.4 (Character Key Shortcuts) by accurately syncing ARIA shortcut attributes with the actual state of keydown event listeners.
PR created automatically by Jules for task 14633272726975116112 started by @ightevenmckane187