🛡️ Sentinel: Fix side-channel timing vulnerability in API key verification - #449
Conversation
Replaces non-constant-time string equality check in `verify_api_key` in `auth.py` with `hmac.compare_digest` to prevent timing side-channel attacks on secret API key comparisons. Adds unit test coverage for invalid key rejection.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
🛡️ Sentinel Security Patch:
!=) inverify_api_key(auth.py) exposed the API key authentication gate to side-channel timing analysis attacks.hmac.compare_digest(provided_key, CYPHER_API_KEY)to enforce constant-time API key comparisons.test_api_create_share_link_timing_safetyintests/test_share_system.pyasserting rejection of invalid keys of various lengths and formats. Updated.gitignoreto prevent database test artifacts from tracking. All 24 Python unit tests and 199 Jest tests pass.PR created automatically by Jules for task 2947057660451506288 started by @ightevenmckane187