Merged
Conversation
schurchleycci
force-pushed
the
phase-2c/composition-root
branch
from
c841a6a to
685874a
Compare
schurchleycci
force-pushed
the
phase-2a/fix-import-direction
branch
from
ffddafb to
19ef5b5
Compare
schurchleycci
force-pushed
the
phase-2c/composition-root
branch
from
685874a to
9402298
Compare
schurchleycci
changed the title
schurchleycci
force-pushed
the
phase-2a/fix-import-direction
branch
from
19ef5b5 to
6f5faf8
Compare
Contributor
|
src/commands/build-prompt.ts:90 - The |
danmux
approved these changes
Mar 11, 2026
schurchleycci
force-pushed
the
phase-2c/composition-root
branch
2 times, most recently
from
08e5371 to
f5a54d9
Compare
Contributor
Author
Good catch, this is addressed now! |
schurchleycci
changed the title
Move command-specific CLI definitions (flags, help text, examples, parser helpers, option defaults) out of src/index.ts into their respective src/commands/* modules. Each command module now exports a register*() function that takes the Commander program and registers itself, following the same pattern already used by @chunk/hook's registerHookCommands(). This keeps index.ts limited to program creation, command registration calls, and top-level error handling. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Drop explicit ParsedBuildPromptFlags annotation on .action() callback, letting Commander infer the type (consistent with task.ts) - Un-export ParsedBuildPromptFlags, runAuthStatus, runAuthLogout since they are now only used within their own modules - Remove duplicate -h/--help line from build-prompt addHelpText Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Remove unnecessary exports from runConfigShow, runConfigSet, and runTaskConfig now that registration functions are the public API. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
hanabel1
force-pushed
the
phase-2c/composition-root
branch
from
39868c6 to
c59951b
Compare
Move sandbox command registration out of index.ts and into a registerSandboxCommands() function in commands/sandbox.ts, matching the pattern used by all other command modules. Handler functions are made private; validatePublicKey and resolvePublicKeyFile remain exported for unit tests. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/index.tsinto correspondingsrc/commands/*modulesregister*Command(program)functionsrc/index.tsreduced to ~50 lines: program creation, registration calls, and error handlingWill wait until #74 is merged and rebase this branch so we don't have to move things around twice.
Test plan
bun run typecheckpasses--help, etc.)🤖 Generated with Claude Code