Aci link level flow control (DCNE-595) #1413
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akinross
requested review from
anvitha-jain,
gmicol,
lhercot,
sajagana,
samiib and
shrsr
as code owners
github-actions
bot
changed the title
akinross
force-pushed
the
aci_link_level_flow_control
branch
from
c8cf587 to
2b7fb8d
Compare
…ss policy with resource aci_link_level_control_flow_interface_policy
akinross
force-pushed
the
aci_link_level_flow_control
branch
from
2b7fb8d to
2142500
Compare
samiib
requested changes
Dec 23, 2025
| * `annotation` (annotation) - (string) The annotation of the Link Level Flow Control Interface Policy object. | ||
| - Default: `"orchestrator:terraform"` | ||
| * `description` (descr) - (string) The description of the Link Level Flow Control Interface Policy object. | ||
| * `receive_mode` (llfcRcvAdminSt) - (string) The receive mode of the Link Level Flow Control Interface Policy object. |
Collaborator
There was a problem hiding this comment.
Should these be receive state or similar? To me using mode implies there are multiple options instead of on or off.
The UI says Receive/Send Flow Control. I think either receive_flow_control or receive_state?
Collaborator
Author
There was a problem hiding this comment.
To me the terminology of state could imply that it could be multiple options this is why I chose mode. But I guess it it is interpretation specific. Changed to state now, because I do not like the flow_control behind receive since it is already in the object/resource name.
akinross
force-pushed
the
aci_link_level_flow_control
branch
from
9077aeb to
62a3f62
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.