Draft
Conversation
Minimum allowed line rate is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue 1: Silent Exception Swallowing ✅ FIXED
Problem: ThreadPoolExecutor wasn't checking for exceptions.
Solution: Added proper exception handling with future.result() to catch and log all failures.
Issue 2: Thread-Safety Race Condition ✅ FIXED (NEW)
Problem: Multiple threads writing to the same ZipFile object simultaneously.
Error: Can't write to ZIP archive while an open writing handle exists.
Solution: Added threading.Lock() to synchronize all ZIP file writes.
Protected operations:
_save_image_to_archive() - line 148
_save_text_to_archive() - line 164
_save_audio_to_archive() - line 183
_save_video_to_archive() - line 206
_save_annotation_to_archive() - line 231
Issue 3: Timeout Handling ✅ FIXED
Problem: No timeouts on HTTP requests.
Solution: Added 60s timeout for images/text/audio, 120s for videos.
Issue 4: Detailed Error Logging ✅ FIXED
Problem: No visibility into what failed or why.
Solution: Added comprehensive logging with input IDs and error messages.