feat: Better debug information (AAInfo) pt.2#525
Merged
kappa-maintainer merged 4 commits intoCleanroomMC:mainfrom Mar 8, 2026
Merged
feat: Better debug information (AAInfo) pt.2#525kappa-maintainer merged 4 commits intoCleanroomMC:mainfrom
kappa-maintainer merged 4 commits intoCleanroomMC:mainfrom
Conversation
- furnace fuel burn time display - hold SHIFT to display advanced info (ore dicts, unlocalized name) - hold CTRL to display NBT list - multilingual support (only enus, jajp, zhcn, zhtw)
Contributor
There was a problem hiding this comment.
Pull request overview
Adds additional item tooltip debug information to support the AAInfo roadmap items (burn time display + modifier-key-gated advanced details), plus localization keys and a config knob to cap NBT tooltip length.
Changes:
- Add localized tooltip strings for burn time, advanced info (SHIFT), and NBT listing (CTRL) across multiple locales.
- Add a new early config value to cap the displayed NBT string length in tooltips.
- Extend
ItemStacktooltip generation to show burn time, ore dictionary IDs, translation key, and (optionally) truncated NBT.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
src/main/resources/assets/forge/lang/zh_tw.lang |
Adds Traditional Chinese translations for the new tooltip keys. |
src/main/resources/assets/forge/lang/zh_cn.lang |
Adds Simplified Chinese translations for the new tooltip keys. |
src/main/resources/assets/forge/lang/ru_ru.lang |
Adds new tooltip keys (currently English text). |
src/main/resources/assets/forge/lang/ko_kr.lang |
Adds new tooltip keys (currently English text). |
src/main/resources/assets/forge/lang/ja_jp.lang |
Adds Japanese translations for the new tooltip keys. |
src/main/resources/assets/forge/lang/fr_fr.lang |
Adds new tooltip keys (currently English text). |
src/main/resources/assets/forge/lang/es_es.lang |
Adds new tooltip keys (currently English text). |
src/main/resources/assets/forge/lang/en_us.lang |
Adds the canonical English strings for the new tooltip keys. |
src/main/resources/assets/forge/lang/en_pt.lang |
Adds new tooltip keys (but not in pirate style used by this locale). |
src/main/java/net/minecraftforge/common/ForgeEarlyConfig.java |
Introduces MAX_TOOLTIP_NBT_LIST_LENGTH to cap tooltip NBT output. |
patches/minecraft/net/minecraft/item/ItemStack.java.patch |
Implements burn time + SHIFT/CTRL-gated advanced tooltip information and NBT display. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Collaborator
|
Looks good to me |
Collaborator
|
Wait |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Roadmap
I'm sorry I dont know how to use git.