Repository navigation
fix(cc-link): do not treat mailto: and tel: links as opening a new window - #1893
Merged
Merged
Conversation
Contributor
|
🔎 A preview has been automatically published : https://clever-components-preview.cellar-c2.services.clever-cloud.com/fix/cc-link-mailto-tel/index.html. This preview will be deleted once this PR is closed. |
pdesoyres-cc
approved these changes
Nov 12, 2026
pdesoyres-cc
left a comment
pdesoyres-cc
left a comment
Contributor
There was a problem hiding this comment.
nitpick: I'm not sure with the use of the term "app" since it introduces ambiguity with clever application.
clara-layus-cc
force-pushed
the
fix/cc-link-mailto-tel
branch
from
November 12, 2026 14:44
b5fef66 to
84cf0b6
Compare
clara-layus-cc
force-pushed
the
fix/cc-link-mailto-tel
branch
from
November 12, 2026 14:46
84cf0b6 to
c343de3
Compare
Contributor
|
🔎 The preview has been automatically deleted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1460
What does this PR do?
mailto:andtel:links as external incc-link: no moretarget="_blank",rel="noreferrer", "new window" title suffix or external link icon,mailtoAndTelLinksstory.How to review?