Skip to content

deploy(pulsar): rework the pages from the tested behavior of the add-on, its API, and its tokens - #1105

Merged
davlgd merged 4 commits into
mainfrom
davlgd-pulsar
Nov 11, 2026
Merged

davlgd merged 4 commits into
mainfrom
davlgd-pulsar

Conversation

@davlgd

@davlgd davlgd commented Nov 11, 2026

Copy link
Copy Markdown
Collaborator

📝 Summary

This PR reworks the Pulsar pages from the behavior of the add-on. Code and behavior checked: each command and example was run on the platform, with pulsarctl, the admin API of Pulsar, the Clever Cloud API, and the Python, Java, and Rust clients.

  • The Rust example uses Magnetar, added to the Vale vocabulary
  • The environment variables reference describes the Pulsar variables as the add-on sets them
  • Eclipse Biscuit is named at its first mention, with a link to its documentation, on the pages that use it

🧪 Type of Change

  • ⚠️ Bug fix
  • 📅 Changelog update
  • 📚 Documentation update
  • ✨ New content/feature
  • 🔧 Technical/maintenance

✅ Validation

  • Read the contributing guidelines
  • Verify content accuracy and links
  • Run relevant checks and builds
  • Check the rendered result when the change affects layout or formatting

@davlgd
davlgd deployed to update doc November 11, 2026 13:23 — with GitHub Actions Active
@github-actions

github-actions Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

👋` Review app deleted

You closed this PR and deleted the review app.

@davlgd
davlgd deployed to update doc November 11, 2026 15:22 — with GitHub Actions Active
@davlgd
davlgd requested a balanced review from Copilot November 11, 2026 15:22

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The Pulsar setup examples use an unquoted <addon-id> placeholder that the shell interprets as redirections, causing the commands to fail before environment variables can be loaded.

1 open issue

Review effort: Balanced

Comment thread content/doc/deploy/pulsar/examples.md Resolved

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The replay guidance links to reader examples that leave the durable DLQ backlog intact and needs to distinguish inspection from draining with a consumer that acknowledges each message.

1 open issue
1 resolved since last review

Review effort: Balanced

Comment thread content/doc/deploy/pulsar/examples.md Resolved

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Platform-maintainer confirmation is needed for storage-policy PATCH semantics, deletion delays, and token lifetime/revocation guarantees that cannot be verified from the available sources.

No open issues 🎉

1 resolved since last review

Review effort: Balanced

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The documentation must clarify that --add-ttl 1h is not a hard access cutoff, since already-authorized producers and consumers can retain access after expiry until disconnection or another permission check.

1 open issue

Review effort: Balanced

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Platform-owner verification is needed because the checkout lacks implementation or API contracts to validate data-loss-sensitive storage-policy PATCH omission/reset semantics and delayed namespace/Cellar deletion offline.

No open issues 🎉

1 resolved since last review

Review effort: Balanced

@davlgd
davlgd merged commit 67f55c8 into main Nov 11, 2026
7 checks passed
@davlgd
davlgd deleted the davlgd-pulsar branch November 11, 2026 22:13

This branch was successfully deployed

1 active deployment
update doc — 77750670 Deployed Nov 11, 2026 by davlgd via Check externally maintained guides #1803
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants