Delay WallTimeInfo until cbs are compiled - #4591
Open
imreddyTeja wants to merge 1 commit into
Open
Conversation
1 task
Contributor
|
📖 Docs preview for this PR: https://clima.github.io/ClimaAtmos.jl/previews/PR4591/ |
imreddyTeja
force-pushed
the
tr/sypd-rep
branch
3 times, most recently
from
June 16, 2026 20:47
1ff8c5c to
d5c14d3
Compare
imreddyTeja
marked this pull request as ready for review
June 16, 2026 21:49
mod order cap delay change kwarg improve comments
| callbacks = (callbacks..., progress_logging_callback(dt, t_start, t_end)...) | ||
| # avoid estimating SYPD until the above (non-cleanup cbs) callbacks are compiled. | ||
| # raw SYPD between each call is still reported | ||
| steps_per_cycle = n_steps_per_cycle(callbacks, dt) |
Member
There was a problem hiding this comment.
I'm not sure that this changes progress logging in the intended way. I think steps_per_cycle will always equal 1 since the function n_steps_per_cycle only sees the conservation callback, resulting in sypd_estimate_step_delay = 10. To fix I think we need to call n_steps_per_cycle on the full list of callbacks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Delay estimating sypd until either a quarter of the tspan is finished, or all non-post-simulation callbacks are called at least once.
We don't need to merge this if people prefer the old behavior.
I excluded the nan check callback because the default period is 1024 steps.
Purpose
To-do
Content