Capture lossy telemetry flags after positionals (#342)

[sdairs]

Summary

• consume clap-defined positional arguments during failed-parse telemetry capture without recording their values
• continue capturing later canonical flag names while stopping conservatively at unmatched input and --
• cover required, optional, variadic, flag-like, and subcommand-like positional cases plus the cloud org usage failed-parse payload

Tests

• cargo test -p clickhousectl --bin clickhousectl lossy
• cargo test -p clickhousectl --test telemetry_test failed_parse_after_positional_captures_later_flags_without_values -- --exact
• cargo test -p clickhousectl
• cargo clippy -p clickhousectl --all-targets -- -D warnings

Closes #342

[Copilot]

Pull request overview

This PR fixes a telemetry gap in clickhousectl where failed-parse (“lossy”) telemetry stopped at the first positional argument and therefore missed valid flags that appeared later in argv. It extends the definition-anchored argv walker to consume clap-defined positional slots without recording their values, so it can continue capturing later canonical flag names while still stopping at unknown tokens and -- to preserve privacy guarantees.

Changes:

• Teach capture_lossy() to advance over positional arguments (including multi-value and hyphenated-value cases) without retaining any positional/flag values.
• Improve lossy handling for hyphenated tokens (including short clusters) so positional-vs-flag decisions stay conservative and definition-driven.
• Add both unit tests and an end-to-end regression test covering the cloud org usage ORG_ID --from-date ... --to-date ... reproduction and multiple positional shapes.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
crates/clickhousectl/src/telemetry.rs	Extends lossy argv walking with a positional cursor so later flags can be captured without ever recording argument values.
crates/clickhousectl/tests/telemetry_test.rs	Adds an end-to-end regression test ensuring flags after a positional are captured and secret argument strings never appear in telemetry payloads.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.