Simplyfing dbt-clickhouse codebase to make it easier to develop in dbt Core 2.0#678
Simplyfing dbt-clickhouse codebase to make it easier to develop in dbt Core 2.0#678koletzilla wants to merge 6 commits into
Conversation
| return '' | ||
|
|
||
| @available | ||
| def is_before_version(self, version: str) -> bool: |
There was a problem hiding this comment.
Isn't that a useful functionality to have in a project?
I understand that the changes in this PR make this function/logic redundant, but generally, it sounds plausible to have version-based checks.
There was a problem hiding this comment.
100% agree on this functionality may be useful in the future, but keeping these now-unused functions is adding a bit of noise so I'd like to get rid of it.
I'm encountering many situations were I can't just "copy-paste" logic from dbt-clickhouse to dbt-fusion and that logic is making all things harder to move as I need to figure out how these things should be done in Fusion now.
I prefer to go more lean now: Remove what is unused so I'm faster moving real features to dbt Core. If in the future we need them again, we can just go back in git and copy the code.
I have changed this PR back to a draft as I'm encountering other things that can be simplified. I'll add them here and put it back to a regular PR once I have a nice set of features to review.
There was a problem hiding this comment.
I'm finally not going to remove the base methods. We are going to need them for #680
|
PR moved back to draft as it's WIP |
2 participants
Summary
[1] https://benchmark.clickhouse.com/versions/#version=+.6..3|6..31|2224|1...24&dataset=-&metric=hot&queries=-