fix: advertise tmux extkeys for all terminals (Shift+Enter) - #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shift+Enterdidn't reach agent TUIs (e.g. Pi) inside ExitBox's tmux. The generated tmux config advertised the Kitty extended-keys feature only forxterm*terminals (terminal-features "xterm*:extkeys"), so terminals whoseTERMisn'txterm*never had extended keys negotiated, and modified-Enter was lost.Fix
Advertise extkeys for all terminals:
set -as terminal-features "*:extkeys"(matches Pi's documented tmux recommendation).set -g extended-keys onunchanged. Terminals that don't support the protocol simply don't get it negotiated — no regression.Ctrl+Jremains the universal newline fallback (Pi binds it by default).Tests
Updated
write_tmux_confassertion to check the*:extkeyswildcard. Entrypoint suite: 105 pass, 2 pre-existing failures (codex session-storage env leakage onmain, unrelated).Note: entrypoint ships in the base image, so this needs an image rebuild to take effect.