feat: --no-tmux to run agents without the tmux wrapper - #27
Merged
Conversation
Contributor
Merging this branch will not change overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pi (and other Kitty keyboard-protocol TUIs) work best owning the terminal directly. ExitBox always wrapped agents in tmux, and tmux's modified-key re-encoding (
Shift+Enter, evenCtrl+J) is a fragile extra hop for Pi specifically — other agents tolerate it. This adds an opt-out so Pi can run with no tmux in the way.What
exitbox run <agent> --no-tmuxruns the agent directly (entrypointrun_agent_once), skipping the tmux session wrapper.EXITBOX_NO_TMUX=1→should_start_tmuxreturns false → the agent execs directly with full workspace setup (config symlinks, sandbox instructions, skills) still applied.--help): no tmux status bar, workspace switcher (Ctrl+M+P), or tmux-based session resume. Fine for Pi, which manages its own sessions.This complements the in-tmux fixes already on
main(extended-keys on,extended-keys-format csi-u,terminal-features *:extkeys): use those if you want tmux + modified keys; use--no-tmuxfor the most reliable Pi experience.Tests
parseRunFlagstest covers--no-tmux(set + default-off).go build,go test ./...,go vet,golangci-lintgreen; entrypoint suite 106 pass / 2 pre-existing fails.Note: the entrypoint ships in the base image — needs an image rebuild to take effect.