fix: tmux-256color default-terminal for extended keys (Pi Shift+Enter) - #28
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pi's modified keys (Shift+Enter, Ctrl+J) do nothing inside ExitBox's tmux, even with
extended-keys on+extended-keys-format csi-u+terminal-features *:extkeys(all already on main). They DO work with--no-tmux, but tmux is required for ExitBox's status bar / workspace switcher / session resume.Cause
The generated tmux config set
default-terminal "xterm-256color". Thexterm-256colorterminfo does not declare the extended-key capabilities tmux relies on to expose modified keys to inner programs;tmux-256color(the value the tmux project recommends) does. With xterm-256color, Pi's Kitty/extended-keys negotiation through tmux doesn't yield modified keys.Fix
Set
default-terminal "tmux-256color"(terminfo ships in Alpine'sncurses-terminfo-base, already in the base image), with a safeinfocmpfallback toxterm-256colorif the entry is ever missing.Tests
New
test_write_tmux_conf_default_terminal: stubsinfocmpto assert tmux-256color is chosen when available and xterm-256color when not. Entrypoint suite: 108 pass, 2 pre-existing failures (codex session-storage env leakage, unrelated).Note: entrypoint ships in the base image — needs an image rebuild to take effect.