fix: install codex-code-mode-host alongside codex (code review) - #32
Merged
Conversation
Contributor
Merging this branch will not change overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recent Codex versions spawn a sibling binary
codex-code-mode-hostfor the new code-review / "code mode" feature. It ships as a separate release asset, but ExitBox only downloaded the maincodextarball — so code review failed with:Fix
CodeModeHostBinaryName()returns thecodex-code-mode-host-<arch>-unknown-linux-musl.tar.gzasset.PrepareBuildnow downloads it too, computes its SHA-256, and passes it asCODEX_CODE_MODE_HOST_CHECKSUM.GetDockerfileInstallCOPYs + checksum-verifies + extracts it to$HOME/.local/bin/codex-code-mode-host, next to thecodexbinary (verified the tarball extracts tocodex-code-mode-host-<arch>-unknown-linux-musl, same convention as codex).Codex looks for the host binary beside itself / on PATH, and
$HOME/.local/binis both — so code review works after a rebuild.Tests
codex_test.go: assertCodeModeHostBinaryName()per arch, and thatGetDockerfileInstallinstallscodex-code-mode-host+ verifies its checksum.go build,go test ./...,go vet,golangci-lintgreen.Caveat: pinning
agents.codex.versionto a very old release (before the code-mode-host asset existed) will now fail the download; use latest (the default). Needs an image rebuild (exitbox run codex --update).