fix: improve paperclip indicator checks to support e.g. leafmc #1847
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0utplay
added
v: 4.X
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
With #1839 the wrapper was converted into a java agent which resulted in a regression regarding leafmc support.
Modification
Instead of strictly checking on the paperclip package & class name we now only check on an existing version list (used by paperclip) and the existance of a method called
extractAndApplyPatchesinside a class in the same package as the main class is located in.Result
Paperclip, Leaf's QuantumLeaper and possible other paperclip variants are supported.
Other context
Results from this conversation https://discord.com/channels/325362837184577536/818777626663321671/1465822591880003787