Skip to content

Adding basic CICD, commenting out old CICD, disabling nx cloud#111

Merged
maxn990 merged 17 commits intomainfrom
New-CICD
May 5, 2026
Merged

Adding basic CICD, commenting out old CICD, disabling nx cloud#111
maxn990 merged 17 commits intomainfrom
New-CICD

Conversation

@SamNie2027
Copy link
Copy Markdown
Contributor

@SamNie2027 SamNie2027 commented Feb 1, 2026

📝 Description

Closes #135

CICD from BHCHP that builds frontend using npx nx build frontend and npx nx build backend and uses yarn to install and run dependencies.

Disables NX cloud so that GitHub Actions workloads don't become limitted.

Frontend build, backend build, linter, and test run are all separate so that there can be clear specificity from the PR page of what failed.

Comments out old CICD, saving it if a team has fully build-out cloud infrastructure for frontend/ backend using app runner and amplify. This CICD is more suitable for projects because it runs everything locally as it would be run locally.

✔️ Verification

Works on the BHCHP repo.

Copy link
Copy Markdown
Member

@maxn990 maxn990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved with a few comments, overall looks really good! maybe we could add some sort of workflows.md file too just to clarify the structure for new tls and also explain why some parts are commented out.

thanks for taking this on, it's much appreciated!

Comment thread .github/workflows/ci-cd.yml
Comment thread .github/workflows/lint.yml
@thaninbew thaninbew self-requested a review February 3, 2026 19:05
Copy link
Copy Markdown

@thaninbew thaninbew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good! I also disabled Nx cloud in the FCC repo.

my review from looking at your file changes:

Agreed with Max's points:

  • adding clarity to documentation will be best, especially if scaffolding's gonna continue to be the norm for new C4C projects. "make it clear (in comments) that this is an example workflow for deployment"
  • I also think that we should keep nx affected if there wasn't any specific reason for removing it, since our projects can get large and linter can get slow.

Additional:

  • workflow files, (i.e. backend_build.yml and others..) should have trailing newlines at the end (I also lowkey forget, but it's best practice)
  • added a comment on the lint.yml file

Comment thread .github/workflows/lint.yml Outdated
swarkewalia pushed a commit that referenced this pull request Mar 30, 2026
* fix auth check and rename formRequests

* review comments
@maxn990 maxn990 requested a review from thaninbew May 5, 2026 14:05
@maxn990 maxn990 merged commit 5d14f5c into main May 5, 2026
4 checks passed
@maxn990 maxn990 deleted the New-CICD branch May 5, 2026 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add CI

3 participants