Skip to content

SSF-200 Login Logic Improvements#168

Open
Juwang110 wants to merge 5 commits intomainfrom
jw/ssf-200-login-page-improvements
Open

SSF-200 Login Logic Improvements#168
Juwang110 wants to merge 5 commits intomainfrom
jw/ssf-200-login-page-improvements

Conversation

@Juwang110
Copy link
Copy Markdown

ℹ️ Issue

Closes https://vidushimisra.atlassian.net/jira/software/projects/SSF/boards/1?selectedIssue=SSF-200

📝 Description

Added functionality:

  • Redirect when user logs in when they are already logged in (instead of error message)
  • Descriptive error alert messages for different types of login errors
  • User can press enter button to login

✔️ Verification

Verified changes were functional

🏕️ (Optional) Future Work / Notes

N/A

@dburkhart07 dburkhart07 self-requested a review April 30, 2026 01:17
@dburkhart07
Copy link
Copy Markdown

Per the ticket requirements, can we remove the Login and Signup navigation options if the user is signed in? They still appear for me:
image

Copy link
Copy Markdown

@dburkhart07 dburkhart07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also confirm with Yurika if we want to allow enter key? I wonder if the forgot password enter should Send the verification code, and if the forgot password enter should reset the password if we have all the fields there.

Comment thread apps/frontend/src/containers/loginPage.tsx
@Juwang110
Copy link
Copy Markdown
Author

Can we also confirm with Yurika if we want to allow enter key? I wonder if the forgot password enter should Send the verification code, and if the forgot password enter should reset the password if we have all the fields there.

Will confirm!

@Juwang110 Juwang110 requested a review from dburkhart07 April 30, 2026 15:00
Copy link
Copy Markdown

@dburkhart07 dburkhart07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pending changes from whether or not yurika thinks we should add enter anywhere else throughout the login/signup/forgot password/reset password process, but i trust those changes will be very similar to the code here, so ill approve!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants