feat(beta): format with prettier - #71
Open
vasfvitor wants to merge 3 commits into
Open
Conversation
✅ Deploy Preview for advanced-astro-kit-i18n ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Collaborator
|
I'm not against using Prettier, but I've been having annoying conflicts when using different languages, different repos, some with, some without prettier. Let's table this one for another time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
de79871 are the actual changes
also added 737c22d but is only worth if we actually hook as a branch rule to only merge if it pass, this way we ensure every PR is formatted and the codebase doesn't drift. If not then I'll remove it from the PR. First apply the rule to the beta branch, then later to the main branch once this version get released
the formatting config is just the default, most changes are from removing tabs and normalizing EOL to LF. Either if we don't and default to tabs, there will be lots of changes from adding tabs, right now the repo is mixed tabs and spaces. Personally I'd keep useTabs false
btw the reason format the codebase is to make it easier to review a PR, as you can see the actual changes in this PR are very small, but since I formatted almost every file you get those 109 files changed, we just need to enforce formatting to avoid it drifting.