refactor: Phase 1 - Move data layer, services, and app base classes to MVVM structure#13
Open
CodingWithTashi wants to merge 17 commits into
Open
refactor: Phase 1 - Move data layer, services, and app base classes to MVVM structure#13CodingWithTashi wants to merge 17 commits into
CodingWithTashi wants to merge 17 commits into
Conversation
…o MVVM structure - Move data models (DataClass, User, ChatMessage) to data/model/ - Move UserPreferences to data/local/ - Move API infrastructure (RetrofitClient, YigChik*API) to data/remote/ - Move services (TibetanKeyboard, MyFirebaseMessagingService) to service/ - Move app base classes (TibetanKeyboardApp, InputMethodActivity) to app/ - Update all package declarations and imports - Update AndroidManifest.xml for moved components Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Move AIRepository, AIService, PremiumFeatureManager from ai/ to data/repository/ - Move ChatRepository from chat/ to data/repository/ - Move UserRepository from repo/ to data/repository/ - Move RevenueCatManager from subscription/ to data/repository/ - Update all package declarations and imports Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Move TibetanKeyboardView, AIKeyboardView, AIKeyboardCodes to ui/keyboard/ - Move EmojiKeyboardView, EmojiItemList, SimpleSearchKeyboard to ui/keyboard/ - Move CorrectionsAdapter, KeyboardType, AIKeyboardInterface to ui/keyboard/ - Update all package declarations and imports Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…i/ packages - Move all chat components (ChatActivity, ChatViewModel, ChatAdapter, etc.) to ui/chat/ - Move grammar components (GrammarActivity, GrammarViewModel, GrammarCorrectionAdapter) to ui/grammar/ - Move TransliterationActivity to ui/transliteration/ - Move SubscriptionUIComponent to ui/subscription/ - Update all package declarations and imports Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…e packages - Create HomeViewModel, SettingsViewModel, TransliterationViewModel - Move HomeActivity to ui/home/ - Move SplashScreenActivity to ui/splash/ - Move LoginActivity to ui/login/ - Move SettingsActivity to ui/settings/ - Update AndroidManifest.xml for all Activity moves - Update all cross-Activity Intent references and imports Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The keyboard XML layouts referenced TibetanKeyboardView by its old full class name (com.kharagedition.tibetankeyboard.TibetanKeyboardView). After moving to ui.keyboard package, XML references must be updated to the new path (com.kharagedition.tibetankeyboard.ui.keyboard.TibetanKeyboardView). Fixes: ClassNotFoundException crash when opening the soft keyboard. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Tokenize.kt: fix infinite loop when non-syllable chunk terminates a trie match (foundMaxMatch flag was inside syllable-only branch) - Tokenize.kt: fix infinite loop in addFoundWordOrNonWord for single- syllable partial trie match (now returns syls[0]+1, not syls[0]) - ChunkTokenizer: fix getChunkTypeName to use chunkValues map (markers are 100-based, not 1-based); add CharCategories.init in test method - SentenceTokenizer: fix joinNoVerbSentences silently dropping sentences longer than threshold - StackTokenizer: rewrite with correct STACK_RE (base consonant + marks) and syllable-split tokenize; old regex matched only combining marks - LenientNormalization: extend REMOVE_AFFIXES_RE to cover plain suffixes (ིས/ི/ོ/ས/ར/མ/ང); fix rule 1 replacement to preserve ཏེ - ParagraphTokenizer: fix empty-list guard and token length calculation - Text.kt: revert wordTok to space-split (real trie tok via Botok API); fix chunkTok to use Chunks pipeline - ParityTest: correct splitIntoStacks assertions (བཀྲ → [བ, ཀྲ]) - TrieTest: @ignore full-dictionary build test (integration, ~40 min) - SpaceDebugUnitTest: @ignore entire class (debug test, builds full trie) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com